Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add personal pronouns option #11089

Closed
wants to merge 1 commit into from
Closed

doc: add personal pronouns option #11089

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 31, 2017

Checklist
  • documentation is changed or added
  • commit message follows commit guidelinesa
Affected core subsystem(s)

doc

@Trott Trott added the doc Issues and PRs related to the documentations. label Jan 31, 2017
MylesBorins
MylesBorins approved these changes Jan 31, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Were we going to include a link to some documentation about why explicit pronouns is important?

@Trott
Copy link
Member Author

Trott commented Jan 31, 2017

Were we going to include a link to some documentation about why explicit pronouns is important?

I don't have any objection to that. Feel free to push a commit directly to my branch to add that if you want. On the other hand, it could certainly be a separate PR.

jasnell pushed a commit that referenced this pull request Feb 2, 2017
@Trott @jasnell
doc: add personal pronouns option
2a88738 
PR-URL: #11089
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 2, 2017

Landed in 2a88738.
@nodejs/collaborators ... to add your own pronoun preferences, please open a PR. We can update them individually or in batches.

@jasnell jasnell closed this Feb 2, 2017
italoacasas pushed a commit that referenced this pull request Feb 3, 2017
@Trott @italoacasas
doc: add personal pronouns option
4f323cf 
PR-URL: #11089
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@italoacasas italoacasas mentioned this pull request Feb 5, 2017
Merged
@JungMinu JungMinu mentioned this pull request Feb 12, 2017
Closed
2 tasks
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@Trott @italoacasas
doc: add personal pronouns option
3ae25a0 
PR-URL: nodejs#11089
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@JungMinu @italoacasas
doc: update email and add personal pronoun
3db54c9 
Refs: nodejs#11089 (comment)
PR-URL: nodejs#11318
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@Trott @krydos
doc: add personal pronouns option
b5d8af2 
PR-URL: nodejs#11089
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@JungMinu @krydos
doc: update email and add personal pronoun
089a411 
Refs: nodejs#11089 (comment)
PR-URL: nodejs#11318
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@JungMinu @jasnell
doc: update email and add personal pronoun
7a1d236 
Refs: #11089 (comment)
PR-URL: #11318
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@JungMinu @jasnell
doc: update email and add personal pronoun
0d180e0 
Refs: #11089 (comment)
PR-URL: #11318
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@Trott @jasnell
doc: add personal pronouns option
7e89c2a 
PR-URL: #11089
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@Trott @jasnell
doc: add personal pronouns option
f12fd17 
PR-URL: #11089
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@JungMinu @MylesBorins
doc: update email and add personal pronoun
c79d9f9 
Refs: #11089 (comment)
PR-URL: #11318
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott @MylesBorins
doc: add personal pronouns option
8bf7f9f 
PR-URL: #11089
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@JungMinu @MylesBorins
doc: update email and add personal pronoun
6f1db35 
Refs: #11089 (comment)
PR-URL: #11318
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott @MylesBorins
doc: add personal pronouns option
d55d760 
PR-URL: #11089
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@Trott Trott deleted the pronouns branch January 13, 2022 22:42
@panva panva mentioned this pull request Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@evanlucas evanlucas evanlucas approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @jasnell @MylesBorins @evanlucas @addaleax @lpinca @targos @gibfahn